[XDP] Bug fixes to parsing of graph-based xrt.ini settings #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2025 17:06
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
pgschuey
changed the title
jvillarre
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Parsing of some profile/trace settings was not correct
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
A few bugs were found regarding parsing of graph names
How problem was solved, alternative solutions (if any) and why they were rejected
Subgraph support fixed for interface tiles, memory modules, and kernel = all
Risks (if any) associated the changes in the commit
Known issue: support is constrained by metadata. This needs to be updated to better support graphs/subgraphs, core- and DMA-only tiles, etc.
What has been tested and how, request additional testing if necessary
Tested on vck190 and vek280
Documentation impact (if any)
When specifying subgraphs and kernel=all, users will get what they ask for, plus possibly more.