Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Exit run-docker if tool paths are invalid #911

Closed
wants to merge 1 commit into from

Conversation

jmonks-amd
Copy link
Collaborator

If a tool path is invalid (doesn't exist) then run-docker doesn't pass it onto docker. This can lead to errors much later in the build process. Exiting early brings the issue to the users attention immediately.

If a path doesn't exist, a warning will indicate exactly which variables are incorrect before the script exits. Here is an example of all paths badly formed:

VIVADO_PATH: /proj/xbuilds/SWIP/2022.2_1014_8888/installs/lin645/Vivado/2022.2 does not exist
HLS_PATH: /proj/xbuilds/SWIP/2022.2_1014_8888/installs/lin645/Vitis_HLS/2022.2 does not exist
VITIS_PATH: /proj/xbuilds/SWIP/2022.2_1014_8888/installs/lin645/Vitis/2022.2 does not exist
PLATFORM_REPO_PATHS: /opt/xilinx/platforms does not exist

If a tool path is invalid (doesn't exist) then run-docker doesn't pass
it onto docker. This can lead to errors much later in the build process.
Exiting early brings the issue to the users attention immediately.
@jmonks-amd jmonks-amd requested a review from auphelia October 27, 2023 10:37
@auphelia
Copy link
Collaborator

auphelia commented Nov 8, 2023

Hi @jmonks-amd ,

Thanks for the PR! I see your point that the warnings that the tools were not successfully mounted into the container can be overlooked, but I will not merge your PR because of the reason below.

We would like to offer users the possibility to try out certain functionality of FINN and initial investigations network implementation on our FPGAs without the full tool installations. Additionally, it allows us to quickly test certain functionality with GHA.
So, it is acceptable and even necessary that the Docker container can be used without having the tools available.

@auphelia auphelia closed this Nov 8, 2023
@auphelia auphelia deleted the bugfix/tool_path_validation branch November 8, 2023 14:18
@auphelia auphelia removed their request for review November 8, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants