Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vck5000 tests (again) #1992

Merged
merged 4 commits into from
Dec 18, 2024
Merged

fix vck5000 tests (again) #1992

merged 4 commits into from
Dec 18, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Dec 18, 2024

2nd try.

@fifield
Copy link
Collaborator Author

fifield commented Dec 18, 2024

The lowering to vck5000 (in AIETargetHSA) seems to depend on NpuDmaMemcpyNdOp, which I'm not sure is the case any longer in the failing examples. I haven't run locally to learn all the details. There may be more failures masked by REQUIRES peano (i.e. they don't run).

2024-12-18T18:29:56.3638606Z /mlir-aie/programming_examples/basic/matrix_scalar_add/test_vck5000.cpp:113:3: error: no matching function for call to 'invoke_data_movement'
2024-12-18T18:29:56.3639240Z   invoke_data_movement(queues[0], &agents[0], in_a, out);
2024-12-18T18:29:56.3639516Z   ^~~~~~~~~~~~~~~~~~~~
2024-12-18T18:29:56.3640156Z /mlir-aie/build/programming_examples/basic/matrix_scalar_add/aie.mlir.prj/aie_data_movement.cpp:10:6: note: candidate function not viable: requires 2 arguments, but 4 were provided
2024-12-18T18:29:56.3641131Z void invoke_data_movement(hsa_queue_t *q, hsa_agent_t *a) {
2024-12-18T18:29:56.3641428Z      ^
2024-12-18T18:29:56.3641584Z 1 error generated.

In any case the failure makes sense if there are no longer any memcpynd in the generated runtime sequence.

cc: @eddierichter-amd

@fifield
Copy link
Collaborator Author

fifield commented Dec 18, 2024

Based on discussion I've XFAIL'd the tests for now.

@fifield
Copy link
Collaborator Author

fifield commented Dec 18, 2024

@fifield fifield added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@fifield fifield added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit b4070cb Dec 18, 2024
54 of 55 checks passed
@fifield fifield deleted the fix_vck5000_second_try branch December 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants