Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use target model and dynamically create wrapper classes in iron device.py #2005

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Use target model and dynamically create wrapper classes in iron device.py #2005

merged 2 commits into from
Jan 7, 2025

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Jan 7, 2025

Two updates to iron device.py:

  • use target model to query number of rows and columns instead of hard coding
  • create device wrapper classes automatically by iterating AIEDevice enum instead of typing boilerplate

@fifield fifield requested a review from AndraBisca as a code owner January 7, 2025 01:11
@fifield fifield requested a review from jgmelber January 7, 2025 01:11
AndraBisca
AndraBisca approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@AndraBisca AndraBisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from two small comments on the documentation, LGTM!

python/iron/device/device.py Outdated Show resolved Hide resolved
python/iron/device/device.py Outdated Show resolved Hide resolved
@fifield fifield enabled auto-merge January 7, 2025 16:49
@fifield fifield added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@fifield fifield added this pull request to the merge queue Jan 7, 2025
Merged via the queue into Xilinx:main with commit dc34a42 Jan 7, 2025
53 checks passed
@fifield fifield deleted the create_iron_devs branch January 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmelber jgmelber jgmelber approved these changes

@AndraBisca AndraBisca AndraBisca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fifield @jgmelber @AndraBisca