Add topk operator #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josel-amd
force-pushed
the
matthias.topk
branch
from
edc95ff to
bb72770
Compare
Keep consistency with the onnx.topk
josel-amd
force-pushed
the
matthias.topk
branch
from
bb72770 to
c9dfb61
Compare
|
I'm wondering whether we should also infer the type of |
mgehre-amd
commented
Aug 20, 2024
josel-amd
force-pushed
the
matthias.topk
branch
from
e4ba783 to
51363b6
Compare
Set k as an operand
josel-amd
force-pushed
the
matthias.topk
branch
from
51363b6 to
37321a5
Compare
cferry-AMD
reviewed
Aug 20, 2024
josel-amd
force-pushed
the
matthias.topk
branch
from
0f9a0c6 to
64f27ac
Compare
josel-amd
force-pushed
the
matthias.topk
branch
from
64f27ac to
2316e7e
Compare
Check if the types are compatible insteal of equal. Sometimes the result type can be made static and type inference cannot deduce it e.g. when the k is dynamic
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a topk operator