Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topk: allow negative axis #77

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

josel-amd
Copy link
Collaborator

Matches the onnx definition

Copy link
Contributor

@cferry-AMD cferry-AMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/Dialect/XTenNN/IR/XTenNNOps.cpp Outdated Show resolved Hide resolved
test/Dialect/XTenNN/ops_invalid.mlir Outdated Show resolved Hide resolved
test/Dialect/XTenNN/ops_invalid.mlir Outdated Show resolved Hide resolved
Copy link
Collaborator

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/Dialect/XTenNN/IR/XTenNNOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/XTenNN/IR/XTenNNOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/XTenNN/IR/XTenNNOps.cpp Outdated Show resolved Hide resolved
@josel-amd josel-amd merged commit b29a99f into feature/fused-ops Aug 27, 2024
2 checks passed
@josel-amd josel-amd deleted the jose.topk-neg-axis branch August 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants