fix: ensure logs returned by RPC match filter #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncitron
reviewed
Feb 7, 2025
| @@ -31,6 +31,8 @@ pub enum ExecutionError { | |||
| BlockReceiptsRootMismatch(BlockTag), | |||
| #[error("filter not found: 0x{0:x}")] | |||
| FilterNotFound(U256), | |||
| #[error("log does not match filter")] | |||
| LogDoesNotMatchFilter(), | |||
There was a problem hiding this comment.
nit: for consistency with the other errors can we name this LogFilterMismatch
| return false; | ||
| } | ||
| for (i, topic) in filter.topics.iter().enumerate() { | ||
| if let Some(log_topic) = log.topics().get(i) { |
There was a problem hiding this comment.
If the log contains no topic at index i, but the filter does, then this should be viewed as not matching correct? I think we'd want to have an else arm to this that returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.