-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMQ - 2546 - Add telemetry aggregation for clients telemetry #2661
base: main
Are you sure you want to change the base?
Conversation
40c7b94
to
2665f12
Compare
2665f12
to
96e2412
Compare
a15d2c7
to
87413b4
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
87413b4
to
0d127da
Compare
Signed-off-by: Felix Gateru <[email protected]>
a7e9e5d
to
f1aeccf
Compare
Signed-off-by: Felix Gateru <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
- Coverage 43.87% 37.79% -6.09%
==========================================
Files 350 74 -276
Lines 45718 4173 -41545
==========================================
- Hits 20059 1577 -18482
+ Misses 23438 2484 -20954
+ Partials 2221 112 -2109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MQTT events handling is messy. Please remove the event store from the handler and use it as a middleware (so, reimplement the handler with events middleware).
Signed-off-by: Felix Gateru <[email protected]>
What type of PR is this?
This is a feature as it adds a telemetry aggregator for clients telemetry to the journal service.
What does this do?
This pr adds telemetry aggregation from clients and adapters events.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
Yes, in code documentation is included.
Notes