Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMQ - 2546 - Add telemetry aggregation for clients telemetry #2661

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Jan 23, 2025

What type of PR is this?

This is a feature as it adds a telemetry aggregator for clients telemetry to the journal service.

What does this do?

This pr adds telemetry aggregation from clients and adapters events.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No

Did you document any new/modified feature?

Yes, in code documentation is included.

Notes

@felixgateru felixgateru changed the title SMQ - 2546 - Add telemetry aggregator for clients telemetry SMQ - 2546 - Add telemetry aggregation for clients telemetry Jan 23, 2025
@felixgateru felixgateru marked this pull request as ready for review January 24, 2025 08:31
@felixgateru felixgateru requested a review from a team as a code owner January 24, 2025 08:31
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 6.26186% with 494 lines in your changes missing coverage. Please review.

Project coverage is 37.79%. Comparing base (3cb41fa) to head (e300f15).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
journal/service.go 3.50% 219 Missing and 1 partial ⚠️
journal/postgres/telemetry.go 0.00% 109 Missing ⚠️
mqtt/events/streams.go 0.00% 86 Missing ⚠️
journal/mocks/repository.go 0.00% 69 Missing ⚠️
coap/adapter.go 0.00% 4 Missing ⚠️
pkg/messaging/events/pubsub.go 0.00% 3 Missing ⚠️
pkg/messaging/events/events.go 0.00% 2 Missing ⚠️
journal/middleware/authorization.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   43.87%   37.79%   -6.09%     
==========================================
  Files         350       74     -276     
  Lines       45718     4173   -41545     
==========================================
- Hits        20059     1577   -18482     
+ Misses      23438     2484   -20954     
+ Partials     2221      112    -2109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MQTT events handling is messy. Please remove the event store from the handler and use it as a middleware (so, reimplement the handler with events middleware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants