SMQ 2667 - Add: List all the users who can access the entity #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindh <[email protected]>
arvindh123
force-pushed
the
remove_domain_user_2
branch
from
e5dfdc9 to
c344ad5
Compare
Signed-off-by: Arvindh <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
- Coverage 43.87% 38.69% -5.19%
==========================================
Files 350 181 -169
Lines 45718 31735 -13983
==========================================
- Hits 20059 12279 -7780
+ Misses 23438 18500 -4938
+ Partials 2221 956 -1265 ☔ View full report in Codecov by Sentry. |
|
@ianmuchyri Please review and test. |
dborovcanin
requested changes
Jan 30, 2025
api/http/common.go
Outdated
Comment on lines
23
to
79
| MemberKindKey = "member_kind" | ||
| PermissionKey = "permission" | ||
| RelationKey = "relation" | ||
| StatusKey = "status" | ||
| OffsetKey = "offset" | ||
| OrderKey = "order" | ||
| LimitKey = "limit" | ||
| MetadataKey = "metadata" | ||
| ParentKey = "parent_id" | ||
| OwnerKey = "owner_id" | ||
| ClientKey = "client" | ||
| UsernameKey = "username" | ||
| NameKey = "name" | ||
| GroupKey = "group" | ||
| ActionKey = "action" | ||
| ActionsKey = "actions" | ||
| RoleIDKey = "role_id" | ||
| RoleNameKey = "role_name" | ||
| AccessProviderIDKey = "access_provider_id" | ||
| AccessTypeKey = "access_type" | ||
| TagKey = "tag" | ||
| FirstNameKey = "first_name" | ||
| LastNameKey = "last_name" | ||
| TotalKey = "total" | ||
| SubjectKey = "subject" | ||
| ObjectKey = "object" | ||
| LevelKey = "level" | ||
| StartLevelKey = "start_level" | ||
| EndLevelKey = "end_level" | ||
| TreeKey = "tree" | ||
| DirKey = "dir" | ||
| ListPerms = "list_perms" | ||
| VisibilityKey = "visibility" | ||
| EmailKey = "email" | ||
| SharedByKey = "shared_by" | ||
| TokenKey = "token" | ||
| UserKey = "user" | ||
| DomainKey = "domain" | ||
| ChannelKey = "channel" | ||
| ConnTypeKey = "connection_type" | ||
| DefPermission = "read_permission" | ||
| DefTotal = uint64(100) | ||
| DefOffset = 0 | ||
| DefOrder = "updated_at" | ||
| DefDir = "asc" | ||
| DefLimit = 10 | ||
| DefLevel = 0 | ||
| DefStartLevel = 1 | ||
| DefEndLevel = 0 | ||
| DefStatus = "enabled" | ||
| DefClientStatus = clients.Enabled | ||
| DefUserStatus = users.Enabled | ||
| DefGroupStatus = groups.Enabled | ||
| DefListPerms = false | ||
| SharedVisibility = "shared" | ||
| MyVisibility = "mine" | ||
| AllVisibility = "all" |
There was a problem hiding this comment.
Can we logically group these keys (per API?) so we split this large const block?
api/http/util/errors.go
Outdated
| @@ -141,6 +141,9 @@ var ( | |||
| // ErrInvalidComparator indicates an invalid comparator. | |||
| ErrInvalidComparator = errors.New("invalid comparator") | |||
|
|
|||
| // ErrMissingMemberIDs indicates missing group member type. | |||
| @@ -53,6 +53,52 @@ func (req listRolesReq) validate() error { | |||
| return nil | |||
| } | |||
|
|
|||
| type listEntityMembersReq struct { | |||
There was a problem hiding this comment.
Are members = users who can access it? If yes, please change to listEntityUsersReq and add a comment explaining that.
Comment on lines
+30
to
+35
| r.Get("/members", otelhttp.NewHandler(kithttp.NewServer( | ||
| ListEntityMembersEndpoint(svc), | ||
| d.DecodeListEntityMembers, | ||
| api.EncodeResponse, | ||
| opts..., | ||
| ), "list_entity_members").ServeHTTP) |
There was a problem hiding this comment.
Same, use Users instead of members, since we are not talking about groups here.
SammyOina
previously approved these changes
Jan 30, 2025
arvindh123
force-pushed
the
remove_domain_user_2
branch
from
b6fbadf to
b57f107
Compare
ianmuchyri
previously approved these changes
Jan 30, 2025
arvindh123
force-pushed
the
remove_domain_user_2
branch
5 times, most recently
from
f53efcd to
491ba6e
Compare
Signed-off-by: Arvindh <[email protected]>
arvindh123
force-pushed
the
remove_domain_user_2
branch
from
491ba6e to
ca7af6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality:
What does this do?
List all the users who can access the entity
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
Example Request :
Method: GET