feat: vocabulary support for namespace scoped decorators #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DibyamAgrawal
changed the title
| vocManager.addVocabulary(content); | ||
| }); | ||
| const vocabKeySet=[]; | ||
| const namespaceUpdated = newModelManager.getNamespaces().filter(namespace=>namespace!=='[email protected]' && namespace!=='concerto'); |
There was a problem hiding this comment.
Why is this filtering required?
There was a problem hiding this comment.
removed the filtering.
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
* chore(aliasing): tests import aliasing Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): add new tests Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): upgrade glob to v11 to fix rimraf issue in concerto-types Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): update coverage scollection script for globe upgarde Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): concerto-metamodel bump Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): new test Signed-off-by: sanketshevkar <[email protected]> * fix(aliasing): fix test data Signed-off-by: sanketshevkar <[email protected]> --------- Signed-off-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
…ager (accordproject#979) Signed-off-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: sanketshevkar <[email protected]> Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
DibyamAgrawal
force-pushed
the
dibyam/namespace-vocab
branch
from
0b52413 to
3187ad9
Compare
… dibyam/namespace-vocab Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
Signed-off-by: Dibyam Agrawal <[email protected]>
| * @param {Object} decl - the declaration object | ||
| * @param {Object} dcs - the current dcs json to be parsed | ||
| * @returns {Object} - the collection of collected vocabularies with current dcs | ||
| * @private | ||
| */ | ||
| parseVocabularies(dictVoc, decl, dcs){ | ||
| dictVoc[decl.declaration] = dictVoc[decl.declaration] || { propertyVocabs: {} }; | ||
| parseVocabularies(vocabObject, decl, dcs){ |
There was a problem hiding this comment.
What is happening here? Its a bit unclear what this method is accomplishing, can you add some description?
The part that is confusing here is that what's relation between decl object and parsing namespace vocabulary?
sanketshevkar
requested changes
Feb 18, 2025
| @@ -37,7 +37,6 @@ export interface IRange extends IConcept { | |||
|
|
|||
| export interface ITypeIdentifier extends IConcept { | |||
| name: string; | |||
| resolvedName?: string; | |||
There was a problem hiding this comment.
I think you are not working on the latest main branch of concerto.
| @@ -113,6 +115,10 @@ class Vocabulary { | |||
| * @returns {string} the term or null if it does not exist | |||
| */ | |||
| getTerm(declarationName, propertyName, identifier) { | |||
| if(DecoratorManager.isNamespaceTargetEnabled() && !declarationName){ | |||
There was a problem hiding this comment.
This will be only true if your global variable is true. For browser code, this will always be false.
| @@ -133,6 +139,10 @@ class Vocabulary { | |||
| * @returns {string} the term or null if it does not exist | |||
| */ | |||
| getElementTerms(declarationName, propertyName) { | |||
| if(DecoratorManager.isNamespaceTargetEnabled() && !declarationName){ | |||
| @@ -308,6 +315,53 @@ class VocabularyManager { | |||
| }; | |||
|
|
|||
| modelManager.getModelFiles().forEach(model => { | |||
| if(DecoratorManager.isNamespaceTargetEnabled()) { //options?.enableDcsNamespaceTarget | |||
There was a problem hiding this comment.
This is not really a good way of checking is this option is enabled or not. We would ideally require the local insatnce of the DecoratorManager to see if the user has enabled the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #858
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname