Skip to content

feat(awc): allow to set a specific sni host on the request #624

feat(awc): allow to set a specific sni host on the request

feat(awc): allow to set a specific sni host on the request #624

Triggered via pull request December 29, 2024 16:05
Status Success
Total duration 1m 55s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 3 warnings
clippy: awc/src/client/connector.rs#L54
[clippy] reported by reviewdog 🐶 error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> awc/src/client/connector.rs:54:19 | 54 | pub fn to_tls(self) -> Self { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]` Raw Output: awc/src/client/connector.rs:54:19:e:error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> awc/src/client/connector.rs:54:19 | 54 | pub fn to_tls(self) -> Self { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]` __END__
clippy: awc/src/connect.rs#L129
[clippy] reported by reviewdog 🐶 error: match expression looks like `matches!` macro --> awc/src/connect.rs:129:19 | 129 | let tls = match head.uri.scheme_str() { | ___________________^ 130 | | Some("https") | Some("wss") => true, 131 | | _ => false, 132 | | }; | |_________^ help: try: `matches!(head.uri.scheme_str(), Some("https") | Some("wss"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::match_like_matches_macro)]` Raw Output: awc/src/connect.rs:129:19:e:error: match expression looks like `matches!` macro --> awc/src/connect.rs:129:19 | 129 | let tls = match head.uri.scheme_str() { | ___________________^ 130 | | Some("https") | Some("wss") => true, 131 | | _ => false, 132 | | }; | |_________^ help: try: `matches!(head.uri.scheme_str(), Some("https") | Some("wss"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::match_like_matches_macro)]` __END__
clippy: awc/src/client/connector.rs#L54
[clippy] reported by reviewdog 🐶 error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> awc/src/client/connector.rs:54:19 | 54 | pub fn to_tls(self) -> Self { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]` Raw Output: awc/src/client/connector.rs:54:19:e:error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> awc/src/client/connector.rs:54:19 | 54 | pub fn to_tls(self) -> Self { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]` __END__
clippy: awc/src/connect.rs#L129
[clippy] reported by reviewdog 🐶 error: match expression looks like `matches!` macro --> awc/src/connect.rs:129:19 | 129 | let tls = match head.uri.scheme_str() { | ___________________^ 130 | | Some("https") | Some("wss") => true, 131 | | _ => false, 132 | | }; | |_________^ help: try: `matches!(head.uri.scheme_str(), Some("https") | Some("wss"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::match_like_matches_macro)]` Raw Output: awc/src/connect.rs:129:19:e:error: match expression looks like `matches!` macro --> awc/src/connect.rs:129:19 | 129 | let tls = match head.uri.scheme_str() { | ___________________^ 130 | | Some("https") | Some("wss") => true, 131 | | _ => false, 132 | | }; | |_________^ help: try: `matches!(head.uri.scheme_str(), Some("https") | Some("wss"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::match_like_matches_macro)]` __END__
fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint-docs
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636