Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update the usage of JSX blog post to the current version of… #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muco-rolle
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The current Kitajs version (4.1.0) raises a warning that global registering will be deprecated in the next major version (https://github.com/kitajs/html/tree/master/packages/html#deprecating-global-register). Therefore, I thought updating the installation method would help future users avoid any issues.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@RomainLanz
Copy link
Member

KitaJS version 4.0 does not work with ESM.

@muco-rolle
Copy link
Contributor Author

That's right. I'm sorry I didn't give it a thorough test since I was using it in another project. They suggest configuring JSX using this old method (https://github.com/kitajs/html/tree/master/packages/html#alternative-way-to-configure-your-tsconfig), and it seems like the support will come in the next version. This can wait for the next stable release.

@thetutlage
Copy link
Member

@muco-rolle Any idea what's the state of Kita right now? Would love to have a working example with their latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants