feat: add transaction example with customer as a parameter #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainLanz
reviewed
Jan 6, 2025
content/docs/guides/transactions.md
Outdated
| @@ -170,6 +170,21 @@ await db.transaction(async (trx) => { | |||
| // highlight-end | |||
| ``` | |||
|
|
|||
| It is possible to give the transaction as a customer, here is a simple example. | |||
There was a problem hiding this comment.
What does this sentence means?
There was a problem hiding this comment.
The aim is to document the fact that you can create an entity with an await Foo.create(..) and give it the transaction.
Currently, the documentation shows that you can do a new Foo() and modify the fields manually. This solution of passing the trx to the client exists and documenting it could I think help several people.
I think I phrased the sentence wrong, what do you think about:
Instead of instantiating your entity using the
newkeyword, you can give the transaction in the client as a parameter.
|
I push the modification, are you happy with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No issue
❓ Type of change
📚 Description
I've added a presentation of how to give the transaction as a client via the builder.
As I'm not documented, several people came to ask me privately how they could do this, so I took the initiative of adding this little piece of code.