Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegionQuadraticQuadBoundary #933

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Feb 7, 2025

This PR fixes the cells-array for midpoints of edges. This also eliminates some warnings in the tests (warnings are captured).

This fixes #932, see also #931.

fix the cells-array for midpoints of edges
@adtzlr adtzlr added the bug Something isn't working label Feb 7, 2025
@adtzlr adtzlr self-assigned this Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (98cbaf0) to head (48d2b03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         181      181           
  Lines        6510     6510           
=======================================
  Hits         6327     6327           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr mentioned this pull request Feb 7, 2025
@adtzlr adtzlr merged commit 7f40c66 into main Feb 7, 2025
5 checks passed
@adtzlr adtzlr deleted the fix-region-quadratic-quad-boundary branch February 7, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong face-cell order in RegionQuadraticQuadBoundary
1 participant