firestore agent storage class #1978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a corresponding cookbook and add the steps to setup firestore and get the required env variables at the top of the cookbook? |
|
Sure! Should I use this mongo storage as an example? |
|
Sure! Please go ahead |
|
OK, I've added cookbook/examples for both PRs @manthanguptaa
…On Mon, Feb 3, 2025, 10:08 PM Manthan Gupta ***@***.***> wrote:
Sure! Please go ahead
—
Reply to this email directly, view it on GitHub
<#1978 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKM2JKZKKRHYITHENNHAD2OBKMNAVCNFSM6AAAAABWJZFFF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZSHE3DGNZRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Comment on lines
+1
to
+7
| """ | ||
| This recipe shows how to store agent sessions in a Firestore database. | ||
| Steps: | ||
| 1. Run: `pip install openai google-cloud-firestore agno` to install dependencies | ||
| 2. Make sure your gcloud project is set up and you have the necessary permissions to access Firestore | ||
| 3. Run: `python cookbook/storage/firestore_storage.py` to run the agent | ||
| """ |
There was a problem hiding this comment.
Can you please add steps to set up gcloud?
Comment on lines
+1
to
+18
| from datetime import datetime, timezone | ||
| from typing import List, Optional | ||
| from uuid import UUID | ||
|
|
||
| try: | ||
| from google.cloud import firestore | ||
| from google.cloud.firestore import Client | ||
| from google.cloud.firestore import CollectionReference | ||
| from google.cloud.firestore_v1.base_query import FieldFilter, BaseQuery | ||
|
|
||
| except ImportError: | ||
| raise ImportError( | ||
| "`firestore` not installed. Please install it with `pip install google-cloud-firestore`" | ||
| ) | ||
|
|
||
| from agno.storage.agent.base import AgentStorage | ||
| from agno.storage.agent.session import AgentSession | ||
| from agno.utils.log import logger |
There was a problem hiding this comment.
Suggested change
| from datetime import datetime, timezone | |
| from typing import List, Optional | |
| from uuid import UUID | |
| try: | |
| from google.cloud import firestore | |
| from google.cloud.firestore import Client | |
| from google.cloud.firestore import CollectionReference | |
| from google.cloud.firestore_v1.base_query import FieldFilter, BaseQuery | |
| except ImportError: | |
| raise ImportError( | |
| "`firestore` not installed. Please install it with `pip install google-cloud-firestore`" | |
| ) | |
| from agno.storage.agent.base import AgentStorage | |
| from agno.storage.agent.session import AgentSession | |
| from agno.utils.log import logger | |
| from datetime import datetime, timezone | |
| from typing import List, Optional | |
| from uuid import UUID | |
| from agno.storage.agent.base import AgentStorage | |
| from agno.storage.agent.session import AgentSession | |
| from agno.utils.log import logger | |
| try: | |
| from google.cloud import firestore | |
| from google.cloud.firestore import Client | |
| from google.cloud.firestore import CollectionReference | |
| from google.cloud.firestore_v1.base_query import FieldFilter, BaseQuery | |
| except ImportError: | |
| raise ImportError( | |
| "`firestore` not installed. Please install it with `pip install google-cloud-firestore`" | |
| ) | |
| def __init__( | ||
| self, | ||
| collection_name: str, | ||
| db_name: Optional[str] = "(default)", |
There was a problem hiding this comment.
Suggested change
| db_name: Optional[str] = "(default)", | |
| db_name: Optional[str] = "agno", |
Comment on lines
+46
to
+54
| def create(self) -> None: | ||
| """Create necessary indexes for the collection""" | ||
| try: | ||
| logger.info( | ||
| f"Unnecessary call to create index for '{self.collection_name}'" | ||
| ) | ||
| except Exception as e: | ||
| logger.error(f"Error creating indexes for collection: {e}") | ||
| raise |
There was a problem hiding this comment.
This seems to be doing nothing at the moment. Is this intentional?
There was a problem hiding this comment.
Please add function signature in all the docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
#1977
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.