-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inappropriate "break in finally" #10434
Conversation
CodSpeed Performance ReportMerging #10434 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10434 +/- ##
==========================================
- Coverage 98.70% 98.69% -0.01%
==========================================
Files 122 122
Lines 37180 37191 +11
Branches 2058 2056 -2
==========================================
+ Hits 36698 36706 +8
- Misses 335 338 +3
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: J. Nick Koston <[email protected]>
Thanks @Cycloctane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thank you!
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ed84464 on top of patchback/backports/3.11/ed84464a62ddd0b271c9ecb2e05d1ce307439ad0/pr-10434 Backporting merged PR #10434 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ed84464 on top of patchback/backports/3.12/ed84464a62ddd0b271c9ecb2e05d1ce307439ad0/pr-10434 Backporting merged PR #10434 into master
🤖 @patchback |
What do these changes do?
Remove break statement inside the finally block in file
aiohttp/webprotocol.py
.Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #9521
Checklist
CONTRIBUTORS.txt
CHANGES/
folder