Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Concurrent redis #2006

Closed
wants to merge 8 commits into from
Closed

Conversation

Flosckow
Copy link
Contributor

@Flosckow Flosckow commented Dec 23, 2024

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Flosckow
Copy link
Contributor Author

@Lancetnik, i am confused by some points of this MR.

  1. I don't understand why it is used in registrator.py is the return type of AsyncApiSubscriber - because it is the parent of all the others?
  2. The implementation in the factory (conditional expressions) is a bit confusing, perhaps it's better to put the arguments for init into the dictionary and where to decompress + expand them?

And in general, if you have any comments, please indicate them.

@Lancetnik
Copy link
Member

@Lancetnik, i am confused by some points of this MR.

  1. I don't understand why it is used in registrator.py is the return type of AsyncApiSubscriber - because it is the parent of all the others?
  2. The implementation in the factory (conditional expressions) is a bit confusing, perhaps it's better to put the arguments for init into the dictionary and where to decompress + expand them?

And in general, if you have any comments, please indicate them.

  1. Yes, it was the simpliest way to resolve types in public API - only and just return the basic class from factory
  2. Yes, it is a good idea, but I think, we can use some kind of DTO via dataclass instead of dict

Anyway, generally PR looks good, but seems like you forget about Stream with autocommit checking (like confluent and kafka does)

@Flosckow Flosckow marked this pull request as ready for review December 24, 2024 15:41
@Flosckow Flosckow closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants