-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert add array to opencv #43
Conversation
Reviewer's Guide by SourceryThis PR reverts changes to the OpenCV array addition implementation and updates benchmark results. The main change simplifies the conditional logic in the add_opencv function and removes the simsimd-based array addition implementation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage ? 57.93%
=======================================
Files ? 20
Lines ? 2223
Branches ? 0
=======================================
Hits ? 1288
Misses ? 935
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Revert the addition of the add_array_simsimd function and refactor the add_opencv function for better handling of uint8 images with specific value types. Update benchmark results to use 500 images, providing a more comprehensive performance analysis across different operations and data types.
Enhancements:
Tests: