Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SaltAndPepper #15

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Updated SaltAndPepper #15

merged 1 commit into from
Feb 2, 2025

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Feb 2, 2025

Summary by Sourcery

Enhancements:

  • Improved the performance of the SaltAndPepper transform.

Copy link

sourcery-ai bot commented Feb 2, 2025

Reviewer's Guide by Sourcery

The pull request updates the benchmark results for the SaltAndPepper transform and other transforms in the comparison table. The benchmark results were updated in the markdown, json, and csv files.

Flow diagram for SaltAndPepper transform benchmark update

graph LR
    A[Run Benchmark] --> B[Update Results]
    B --> C[Update comparison.md]
    B --> D[Update albumentations_results.json]
    B --> E[Update comparison.csv]

    subgraph Results
    C
    D
    E
    end

    style B fill:#f9f,stroke:#333,stroke-width:2px
    style Results fill:#f0f0f0,stroke:#333,stroke-width:1px
Loading

File-Level Changes

Change Details Files
Updated benchmark results for various transforms.
  • Updated the benchmark results for the SaltAndPepper transform.
  • Updated the benchmark results for other transforms.
output/comparison.md
Updated benchmark results in JSON format.
  • Updated the benchmark results to match the markdown file.
output/albumentations_results.json
Updated benchmark results in CSV format.
  • Updated the benchmark results to match the markdown file.
output/comparison.csv

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ternaus ternaus merged commit e534e11 into main Feb 2, 2025
1 check passed
@ternaus ternaus deleted the update_benchmark branch February 2, 2025 01:07
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a significant performance regression in the SaltAndPepper transform (from 2233 ± 35 to 533 ± 8 samples/sec). Could you investigate what caused this ~76% decrease in performance?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant