-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SaltAndPepper #15
Conversation
Reviewer's Guide by SourceryThe pull request updates the benchmark results for the SaltAndPepper transform and other transforms in the comparison table. The benchmark results were updated in the markdown, json, and csv files. Flow diagram for SaltAndPepper transform benchmark updategraph LR
A[Run Benchmark] --> B[Update Results]
B --> C[Update comparison.md]
B --> D[Update albumentations_results.json]
B --> E[Update comparison.csv]
subgraph Results
C
D
E
end
style B fill:#f9f,stroke:#333,stroke-width:2px
style Results fill:#f0f0f0,stroke:#333,stroke-width:1px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a significant performance regression in the SaltAndPepper transform (from 2233 ± 35 to 533 ± 8 samples/sec). Could you investigate what caused this ~76% decrease in performance?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Enhancements:
SaltAndPepper
transform.