[WIP Observability]: add image model observation #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PolarishT <[email protected]>
Signed-off-by: PolarishT <[email protected]>
Signed-off-by: PolarishT <[email protected]>
Signed-off-by: PolarishT <[email protected]>
Signed-off-by: PolarishT <[email protected]>
|
Currently, several image models do not support synchronous calls, so we have to provide an asynchronous implementation. |
Cirilla-zmh
reviewed
Jan 14, 2025
spring-ai-alibaba-core/src/main/java/com/alibaba/cloud/ai/dashscope/api/DashScopeImageApi.java
Outdated
Show resolved
Hide resolved
...-ai-alibaba-core/src/main/java/com/alibaba/cloud/ai/dashscope/image/DashScopeImageModel.java
Outdated
Show resolved
Hide resolved
| while (attempt < maxAttempts) { | ||
| if (!isTaskCompleted(getResultResponse)) { | ||
| getResultResponse = getImageGenTask(taskId); | ||
| Thread.sleep(10000L); |
There was a problem hiding this comment.
Looks like here is a change of default behavior, which should be full discussed and documented.
There was a problem hiding this comment.
Using a spring-retry-template to control the entire lifecycle, may be a good solution.
...m/alibaba/cloud/ai/dashscope/image/observation/DashScopeImageModelObservationConvention.java
Outdated
Show resolved
Hide resolved
...i-alibaba-core/src/test/java/com/alibaba/cloud/ai/dashscope/image/DashScopeImageModelIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: PolarishT <[email protected]>
👌 |
Signed-off-by: PolarishT <[email protected]>
|
cc @Cirilla-zmh |
Signed-off-by: PolarishT <[email protected]>
Signed-off-by: PolarishT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
#223
Describe how to verify it