feat(document-readers): add mysql implements #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuluo-yx
reviewed
Jan 17, 2025
| <artifactId>spring-ai-core</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- MySQL JDBC Driver --> |
There was a problem hiding this comment.
这里需要引入版本吗？我记得 spring ai alibaba 引入 spring boot parent bom，里面是有 mysql jar 包的，可以复用？
There was a problem hiding this comment.
替换成了mysql-connector-j
yuluo-yx
reviewed
Jan 17, 2025
|
|
||
| ### MySQLResource 参数 | Parameters | ||
|
|
||
| | 参数 Parameter | 说明 Description | 默认值 Default | |
There was a problem hiding this comment.
来个默认值？就是 127.0.0.1:3306 root root?
yuluo-yx
reviewed
Jan 17, 2025
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> |
yuluo-yx
reviewed
Jan 17, 2025
| import org.springframework.ai.document.Document; | ||
| import org.springframework.ai.document.DocumentReader; | ||
|
|
||
| import java.sql.*; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL Document Reader Implementation
功能描述 | Feature Description
实现了基于Spring AI的MySQL文档读取器，支持从MySQL数据库读取数据并转换为文档格式。
Implemented a MySQL document reader based on Spring AI, supporting reading data from MySQL database and converting it to document format.
主要特性 | Key Features
Pure JDBC implementation, no additional dependencies required
Support for custom content and metadata columns
Comprehensive error handling and automatic resource cleanup
Support for custom SQL queries
技术实现 | Technical Implementation
Using JDBC to connect MySQL database directly
Supporting flexible field mapping configuration
Implemented automatic resource management and exception handling
Provided comprehensive unit tests
测试覆盖 | Test Coverage
Basic functionality tests: document reading and conversion
Error handling tests: invalid connections and queries
Resource management tests: connection closing and cleanup
文档完善 | Documentation
Provided detailed bilingual README
Included complete usage examples
Added configuration parameter descriptions
Supplemented with notes and best practices
代码规范 | Code Standards
Following Alibaba Java Development Guidelines
Added complete code comments
Implemented unified exception handling
Maintained code simplicity and maintainability