Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #76 #83

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Fix #76 #83

merged 6 commits into from
Oct 30, 2024

Conversation

flystar32
Copy link
Member

@flystar32 flystar32 commented Oct 29, 2024 •
edited
Loading

Describe what this PR does / why we need it

Fix #76

Describe how you did it

  1. 更正 prompts 目标里的 question_answer_context 和 qa_retrieved_documents 不一致的问题
  2. 将知识库的上下文追加到usertext 里，而不是直接替换 systemtext。使得 DashScopeDocumentRetrievalAdvisor 可以和 PromptChatMemoryAdvisor 这类 Advisor 兼
    容

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@robinyeeh
Copy link
Collaborator

LGTM.

chickenlj
chickenlj approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit b5a2054 into alibaba:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

@robinyeeh robinyeeh Awaiting requested review from robinyeeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DashScopeDocumentRetrievalAdvisor doesn't compatible with previous Advisor
4 participants
@flystar32 @CLAassistant @robinyeeh @chickenlj