#51 add memory #87
Closed
#51 add memory #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuluo-yx
reviewed
Nov 3, 2024
| <artifactId>spring-boot-starter-data-redis</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
确定使用这个 orm 框架，或许可以考虑下 mybatis-flux？
yuluo-yx
reviewed
Nov 3, 2024
| <artifactId>spring-boot-starter-data-elasticsearch</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> |
yuluo-yx
reviewed
Nov 3, 2024
| <version>5.7.5</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
可以用 spring boot 自己的序列化框架 jackson
yuluo-yx
reviewed
Nov 3, 2024
| @@ -0,0 +1,38 @@ | |||
| package com.alibaba.cloud.ai.memory.entity; | |||
|
|
|||
| import lombok.Data; | |||
|
Well done. I had a quick review of the code and overall it is what we expect to add for the chat memory feature. The main problem I want to point out is the boundaries of what the framework should do and what the user application should do. As a framework, we need to focus more on basic memory-related component definitions and make sure they are extensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51