Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderCV integration #2787

Open
2 tasks done
m3lixir opened this issue Oct 19, 2024 · 10 comments
Open
2 tasks done

RenderCV integration #2787

m3lixir opened this issue Oct 19, 2024 · 10 comments

Comments

@m3lixir
Copy link

m3lixir commented Oct 19, 2024

Have you checked that your feature request isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my feature request.
  • Yes, I have checked that this feature request isn't already filed.

Description & Motivation

CV page content is generated from either a json or yml. json input conforms to JSON Resume schema (#1513), however there is no schema defined for yml input. I propose we add in RenderCV support and add functionality so that the pdf of the CV can be generated on your current cv.yml (on each push).

Pitch

No response

Alternatives

No response

Additional context

No response

@gmsundar15
Copy link

If RenderCV support is added, it would be great if the JSON resume could be used to automatically generate the downloadable PDF of the CV using RenderCV with each push, just like the yml file.

To achieve this, JSON resume can be easily converted into the CV section of RenderCV with the RenderCV design, locale, and settings being specified using the --design, --locale-catalog and --rendercv-settings runtime options.

@george-gca
Copy link
Collaborator

If you know how to do this, we are welcoming PRs.

@gmsundar15
Copy link

I did try creating a worker to achieve this but there is an open bug report on RenderCV when using external YAML files which causes my approach to fail. I will give it another go once this bug has been fixed.

rendercv/rendercv#272

@george-gca
Copy link
Collaborator

Does it work when using a path without spaces? Because I don't think this is much of an issue, since it is recommended to avoid spaces in directories name. If it works in a path without spaces (like my design/design.yaml), then it is fine. We just add a line in README to warn about avoiding spaces.

@gmsundar15
Copy link

I tried running it locally and get the same error when run without any spaces in the absolute file path. It seems like these runtime options are just completely broken.

@george-gca
Copy link
Collaborator

I sent a PR there (rendercv/rendercv#310). After it gets accepted you can move on with the code.

@gmsundar15
Copy link

I have also added a PR to a different project that converts JSON resume to RenderCV (guruor/jsonresume-to-rendercv#3).

Currently, I only plan to add functionality to automatically convert a JSON resume to a RenderCV PDF. The original request of converting the cv.yml to the RenderCV schema would require major changes to _layouts/cv.liquid.

@george-gca
Copy link
Collaborator

But I think it would be also useful for our users to be able to generate a pdf from the yml. This way both solutions could be used to create render cv pdfs.

@gmsundar15
Copy link

I do agree it would be useful.

I gave it a go (https://github.com/gmsundar15/al-folio). You can view the rendered version at https://gmsundar15.github.io/al-folio/cv/. Needless to say, this deprecates the old cv.yml format.

I will send a PR for this once I do some further improvements and verify that the cv.yml properly follows the RenderCV schema.

As for the GitHub actions to generate the PDF, some decisions have to be made. The conversion from JSON to YAML works well enough, but isn't perfect because these formats have their differences. So there must be some way to give the user control over which file to use for which purpose, for example, giving the option to use the JSON for web view while using the YAML to generate PDF instead of generating both from the same file.

@george-gca
Copy link
Collaborator

I imagine that the user might prefer to keep only one of the solutions updated, and ditch the other one. At least I would rather keep only one.

Maybe in the future we could also add a pre-commit-hook or GitHub action to validate the files against the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants