Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cv.yml to RenderCV schema #2969

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

gmsundar15
Copy link

The cv.yml will follow the RenderCV schema as the first step towards auto-generating CV PDFs from cv.yml or resume.json as discussed in #2787. The YAML file also supports markdown formatting to make it RenderCV friendly.

example_pdf.pdf updated to pdf generated by RenderCV using the example cv.yml file.

The existing cv.yml format would be deprecated after this PR.

Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit df9198d
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/6797ac9af9661200080ae739
😎 Deploy Preview https://deploy-preview-2969--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gmsundar15
Copy link
Author

gmsundar15 commented Jan 19, 2025

The deployed preview defaults to resume.json, so you can't actually see the preview there. But there is an issue with list-group-item:first-child having a top border when it shouldn't have that. I am unable to debug this.
2025-01-19T22:20:41,110015214+00:00

@george-gca
Copy link
Collaborator

I think I can took a look at it tomorrow.

<a class="anchor" id="{{ entry[0] }}"></a>
<div class="card mt-3 p-3">
<h3 class="card-title font-weight-medium">{{ entry[0] | capitalize }}</h3>
{% include cv/education.liquid %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure why, but adding a <div> surrounding this line fixes the extra horizontal line in your layout. I just compared your rendered HTML with the original one and found that it had a <div> less. The same for the other sections with that extra line.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also take a look at this.

@george-gca
Copy link
Collaborator

Sorry for the delay. Just looked at your code and found a fix.

@george-gca george-gca force-pushed the RenderCV-YAML-schema branch from 1b280c3 to df9198d Compare January 27, 2025 15:56
@george-gca
Copy link
Collaborator

Just tried to create an action to validate the yml against the schema, but it is failing. But maybe is because this schema is valid only to be used inside code editors?

@gmsundar15
Copy link
Author

gmsundar15 commented Jan 27, 2025

The JSON Resume to RenderCV converter I was looking at was successfully using a different URL pointing to the same file to validate the schema. https://github.com/guruor/jsonresume-to-rendercv/blob/main/jsonresume_to_rendercv/converter.py

It seems that a new version of RenderCV has been released a couple of days ago with some changes and this cv.yml does not follow the new schema. This could be causing the errors.
I will take a look at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants