-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cv.yml to RenderCV schema #2969
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think I can took a look at it tomorrow. |
<a class="anchor" id="{{ entry[0] }}"></a> | ||
<div class="card mt-3 p-3"> | ||
<h3 class="card-title font-weight-medium">{{ entry[0] | capitalize }}</h3> | ||
{% include cv/education.liquid %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure why, but adding a <div>
surrounding this line fixes the extra horizontal line in your layout. I just compared your rendered HTML with the original one and found that it had a <div>
less. The same for the other sections with that extra line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also take a look at this.
Sorry for the delay. Just looked at your code and found a fix. |
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
1b280c3
to
df9198d
Compare
Just tried to create an action to validate the yml against the schema, but it is failing. But maybe is because this schema is valid only to be used inside code editors? |
The JSON Resume to RenderCV converter I was looking at was successfully using a different URL pointing to the same file to validate the schema. https://github.com/guruor/jsonresume-to-rendercv/blob/main/jsonresume_to_rendercv/converter.py It seems that a new version of RenderCV has been released a couple of days ago with some changes and this cv.yml does not follow the new schema. This could be causing the errors. |
The cv.yml will follow the RenderCV schema as the first step towards auto-generating CV PDFs from cv.yml or resume.json as discussed in #2787. The YAML file also supports markdown formatting to make it RenderCV friendly.
example_pdf.pdf updated to pdf generated by RenderCV using the example cv.yml file.
The existing cv.yml format would be deprecated after this PR.