opentelemetry callback: context propagation and error exception #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
callback
v1v
added a commit
to v1v/opentelemetry-plugin
that referenced
this pull request
Sep 15, 2021
ansibullbot
added
the
needs_revision
felixfontein
added
backport-3
check-before-release
ansibullbot
removed
the
needs_revision
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Sep 16, 2021
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3381 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
* opentelemetry callback: context propagation and error exception * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 0634583)
|
@v1v thanks for contributing this! |
felixfontein
pushed a commit
that referenced
this pull request
Sep 16, 2021
… (#3381) * opentelemetry callback: context propagation and error exception * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 0634583) Co-authored-by: Victor Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/callback/opentelemetry.pyCOMPONENT NAME
ADDITIONAL INFORMATION
Reported errors:
Context propagation:
In order to test this particular plugin you could use jenkinsci/opentelemetry-plugin#166.
NOTE: There is an open discussion open-telemetry/opentelemetry-specification#740 for the traceparent standardisation.