Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit fix for main branch #1448

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Precommit fix for main branch #1448

merged 1 commit into from
Dec 6, 2024

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Dec 6, 2024

Jira Issue: no jira issue

Description

Looks like changes in TS code is not triggering the precommit check. It leads to issues in python code changes in the future when precommit triggered and blocks the PR.

This PR is not fixing the root cause but makes main pipeline green for python code changes.

Testing

Steps to test

  1. Build is green.

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@goneri goneri requested a review from omaciel December 6, 2024 19:38
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Was you also going to fix pre-commit.yaml to cover the Admin Portal too?

@manstis
Copy link
Contributor

manstis commented Dec 6, 2024

@hasys @goneri Please see #1449

@hasys
Copy link
Contributor Author

hasys commented Dec 6, 2024

LGTM 👍

Was you also going to fix pre-commit.yaml to cover the Admin Portal too?

Yes, I will take a look at it, but not today :) For now I reported a Jira issue to track it: https://issues.redhat.com/browse/AAP-37150

@manstis
Copy link
Contributor

manstis commented Dec 6, 2024

Noooooooooooooooooooooooooooooooooooooooooooooooooooooo!

You need to sign your commit 😢

@hasys
Copy link
Contributor Author

hasys commented Dec 6, 2024

Hmm.. strange, just checked the history of my commands and I signed it, probably rebase to main branch erased the sign, but it shouldn't :( I will do it again now, ty Michael

Copy link

sonarqubecloud bot commented Dec 6, 2024

@manstis manstis merged commit 99f863b into main Dec 6, 2024
10 checks passed
@manstis manstis deleted the precommit-2 branch December 6, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants