Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-37349: Ansible Chatbot: Collect referenced documents information as well in issues feedback being created from the UI #1459

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

romartin
Copy link
Contributor

@romartin romartin commented Dec 11, 2024

Jira Issue: https://issues.redhat.com/browse/AAP-37349

Dependency

It depends on ansible/ansible-lightspeed-va-feedback#9

Description

Once creating a GH issue from the chatbot UI's send button (after thumbs down), it also sends to GH issue creation endpoint the query parameter for referenced documents.

Screenshot from 2024-12-12 01-41-08

Testing

Tested locally against the issue template.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Copy link

# npm audit report

nanoid  <3.3.8
Infinite loop in nanoid - https://github.com/advisories/GHSA-mwcw-c2x4-8c55
fix available via `npm audit fix`
node_modules/nanoid

1 low severity vulnerability

To address all issues, run:
  npm audit fix

@romartin romartin force-pushed the AAP-37349-gh-issues-rel-rag-docs branch from c28cc4e to db7ef0e Compare December 11, 2024 23:47
@romartin romartin marked this pull request as ready for review December 11, 2024 23:47
@romartin romartin requested a review from jameswnl December 11, 2024 23:47
@romartin romartin force-pushed the AAP-37349-gh-issues-rel-rag-docs branch 3 times, most recently from 6158a9e to 6f661c3 Compare December 12, 2024 16:00
@jameswnl
Copy link
Contributor

looks good to me. but would like @manstis or @mabashian to help take a look

manstis
manstis previously approved these changes Dec 12, 2024
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

A couple of (minor) comments about m-a-g-i-c numbers.

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romartin

LGTM 👍

…as well in issues feedback being created from the UI

Signed-off-by: romartin <[email protected]>
@romartin romartin force-pushed the AAP-37349-gh-issues-rel-rag-docs branch from c5bb086 to 3aba800 Compare December 12, 2024 20:18
@romartin
Copy link
Contributor Author

just signed the commit... will merge once CI completes. Thanks!

@romartin romartin merged commit ef929ba into main Dec 12, 2024
11 checks passed
@romartin romartin deleted the AAP-37349-gh-issues-rel-rag-docs branch December 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants