-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trial messages in both vscode extension and trial web page #1461
Conversation
I'll have a better look Monday @mabashian but it looks like you'll need some unit tests for the logic. It'd be nice too, in my opinion, if the text could wrap on the HTML page. I also notice the three buttons/links are spread far apart. The footer HTML is different on some of the other pages which makes the buttons group better. They're in the same container as the long text at the moment (The other login pages uses a separate container IIRC). |
@mabashian Regarding the formatting of the buttons on the footer. Look at the "Home page" where they are held in their own "Bullseye" container. This change isn't strictly part of your PR.. but now the text is very long the spacing is more evident. |
@manstis 👍 I'll take a look at that formatting as well |
340dee6
to
04952e8
Compare
@manstis OK I think I've got the footer spacing issue squared away: ![]() Tell me more about |
450f5ec
to
9482e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I think the text is wrapping down to a new line when the screen is more narrow...
Yes it does. The button spacing is much better (and, IMO, more importantly consistent). The (long) length of the single line of text is just my opinion. There's nothing wrong with it.. so ignore me.
This may help with the failing tests: #1466 |
9482e6e
to
5731571
Compare
5731571
to
9ac30ae
Compare
|
Jira Issue: https://issues.redhat.com/browse/AAP-36175
Description
This updates the messages that we present to the user when a trial will expire in <= 90 days as well as when a trial is expired.
Testing
I tested out all of the various scenarios by manipulating the expired_at timestamp on the user plan. There are 4 options/scenarios:
Scenarios tested
See above
Production deployment