DNM/PoC move to vitest-browser-react #1468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, our tests are failing due to some problem with `happy-dom`, the fake webbrowser used to run the tests by `react-testing-library`. `jsdom` is an alternative but we cannot use it without adjusting our tests and facing similar issues or limitations. By moving to `vitest-browser-react`, we are now able to run the tests against a real browser like Chrome or Firefox. We still have the option to run the tests "headless" for a CI environment. `vitest-browser-react` is directly based on `vitest-browser` and allow us to stay in a standard `vite` ecosystem. It also reuses some elements from `react-testing-library`, which explains why the PR is not that large. Overall, this change reduces the differences between our tests and the production environment, and allow use to limit our exposure to the limitations of these dummy browser implementations.
goneri
force-pushed
the
goneri/DNM-PoC-move-to-vitest-browser-react_22109
branch
from
995b7ca to
3633e05
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.