Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbot UI update #1535

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Chatbot UI update #1535

merged 1 commit into from
Feb 14, 2025

Conversation

TamiTakamiya
Copy link
Contributor

@TamiTakamiya TamiTakamiya commented Feb 13, 2025

Jira Issue: n/a

Description

Minor Chatbot UI update on following three points:

  1. Update PF6 chatbot library to 2.2.0-prerelease.21, which includes the fix for Markdown table rendering issue patternfly/chatbot#416
    • Also added @patternfly/react-table and updated eslint-plugin-testing-library and typescript-eslint
  2. Added a small change on the timing to stop showing the waiting icon. Before the change, the waiting icon was deleted when the very first response was received from the chatbot service. It was changed to delete when the first visible data is received. There is a gap between the first response and the first visible data.
    • Aslo added the Accept header for streaming chat. It is needed when the chatbot UI is connected to the new streaming chat endpoint, which is being developed on AI Connect service.

Testing

Steps to test

  1. Pull down the PR
  2. Run unit tests

Scenarios tested

Unit tests + manual test by running the local vite server.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/chatbot-ui-update branch 2 times, most recently from 9efd234 to 8a58b88 Compare February 13, 2025 21:07
@TamiTakamiya TamiTakamiya marked this pull request as ready for review February 14, 2025 02:09
@TamiTakamiya
Copy link
Contributor Author

I changed my dev environment recently and the original commit was not GPG signed. Pushed a new commit with my GPG signature.

Signed-off-by: Tami Takamiya <[email protected]>
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/chatbot-ui-update branch from 9b36320 to 444fb12 Compare February 14, 2025 16:24
@TamiTakamiya TamiTakamiya merged commit c1de7c2 into main Feb 14, 2025
11 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/chatbot-ui-update branch February 14, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants