Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightspeed: remove the client attribute from the LightSpeedManager class #1792

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Jan 29, 2025

Since ab17f51 we don't delegate our requests to the LSP server.
We don't need to keep track of the client object anymore.

Since ab17f51 we don't delegate our requests to the LSP server.
We don't need to keep track of the client object anymore.
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goneri goneri enabled auto-merge (rebase) January 30, 2025 21:41
@goneri goneri merged commit bb52ca6 into main Jan 30, 2025
13 checks passed
@goneri goneri deleted the goneri/lightspeed-remove-the-client-attribute-from-the-LightSpeedManager-class_28716 branch January 30, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants