[C# target] Use Collections.EmptyList to prevent zero length allocations #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corniel
force-pushed
the
use-collections-empty-list
branch
from
d36f817 to
ee12da9
Compare
Signed-off-by: Corniel Nobel <[email protected]>
Corniel
force-pushed
the
use-collections-empty-list
branch
from
ee12da9 to
b5d0bf0
Compare
|
Anyone? |
|
@parrt blessed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when enabling some static code analysis rules (by setting the property
<EnableNETAnalyzers>true</EnableNETAnalyzers>in the csproj file), that CA1825: Avoid zero-length array allocations was raised.Because the C# solution still targets net4.5 (is that still needed? I would argue that net4.8 or netstandard2.0 should be sufficient, it is 2025 after all) the use of
Array.Empty<T>can not be used. However, fortunately,Collections.EmptyList<T>already provided a solution. I just applied them where applicable.