-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for splitting generated Java parser into 3 files #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
* bump-github-action: Bump GH action
Signed-off-by: Eric Vergnaud <[email protected]>
* bump-github-action: Bump GH action
* bump-github-platform: bump macos in github
ericvergnaud
commented
Feb 6, 2025
Nothing seems crazy, but of course it's a widespread change. I'm just going to have to trust you. :) should we update the documentation to include the new options for Java target? |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generator for Java embeds, within the
Parser
class, the serializedATN
andParserRuleContext
subclasses (as static child classes).With large or complex grammars, this can lead to very large parser files that exceed 65k lines.
This is a problem because the JVM does not accept line numbers > 65535, thus making it impossible to debug these parsers.
This PR fixes the problem by adding a
-split-parser
option, that instructs the Tool to generate the serializedATN
and theParserRuleContext
subclasses in dedicated files, thus dramatically reducing the number of lines of the generatedParser
.For the maven plugin, this option can be set using the
<arguments>-split-parser</arguments>
configuration entry.There is no change if this option is not used.