Some grammars needed formatting fixes

[mike-lischke]

The formatter had a few bugs that have been fixed now.

Closes #3863 additional issue with formatting

[mike-lischke]

@kaby76 Looks like the TS tests on macOS hang (since more than an hour). Is that something which happens frequently?

[kaby76]

@kaby76 Looks like the TS tests on macOS hang (since more than an hour). Is that something which happens frequently?

Hey Mike @mike-lischke

Sorry for this mess. This seems to be happening more often nowadays. It was not like this a year or two ago.

The latest Action is hung in macos/TypeScript except for one job. The raw log says this:

2023-12-05T13:46:12.4738938Z Requested labels: macos-latest
2023-12-05T13:46:12.4739338Z Job defined at: antlr/grammars-v4/.github/workflows/main.yml@refs/pull/3871/merge
2023-12-05T13:46:12.4739535Z Waiting for a runner to pick up this job...
2023-12-05T13:54:16.0319057Z Job is waiting for a hosted runner to come online.
2023-12-05T13:54:19.5553997Z Job is about to start running on the hosted runner: GitHub Actions 5 (hosted)

@teverett or @KvanTTT Please kill this github action https://github.com/antlr/grammars-v4/actions/runs/7101621210 . I think you can also just merge it in. Mike's change looks fine.

I've suggested it before, and I think it's time to try some things to avoid the problem. First, I'll remove the Bash testing from the matrix because it's really just duplicate of the Powershell test. If that seems ok, I'll stop there. Otherwise, we might need to drop some of the macos tests. Maybe just do a smaller subset.

[kaby76]

I'm a little suspicious of the raw log detail that Github is giving on this hung job. Let's get this Action canceled, then peek at the full/complete raw log it generated. But, the log so far seems to be saying that Github Actions lost track of the queued job.

Some related posts:
actions/runner#1819
actions/runner#1400
https://stackoverflow.com/questions/70959954/error-waiting-for-a-runner-to-pick-up-this-job-using-github-actions

[kaby76]

It hung during the testing of the PromQL parser.

2023-12-05T14:01:31.3549950Z pddl,TypeScript:
2023-12-05T14:01:48.9252190Z  Build 00:00:15
2023-12-05T14:01:49.5785450Z  Test 00:00:01
2023-12-05T14:01:49.5860780Z  Succeeded.
2023-12-05T14:01:49.6864840Z 
2023-12-05T14:01:49.7872010Z php,TypeScript:
2023-12-05T14:01:50.2985880Z Intentionally skipping grammar php target TypeScript.
2023-12-05T14:01:50.3026970Z 
2023-12-05T14:01:50.3027650Z promql,TypeScript:
2023-12-05T14:02:03.6838630Z  Build 00:00:11
2023-12-05T19:56:31.7020560Z ##[error]The operation was canceled.
2023-12-05T19:56:31.7600660Z Post job cleanup.
2023-12-05T19:56:32.5658970Z Post job cleanup.
2023-12-05T19:56:32.7958260Z [command]/usr/local/bin/git version
2023-12-05T19:56:32.8014720Z git version 2.42.0

That's surprising because I'm pretty sure I had a watchdog on the parser.

It looks like I may need to put a watchdog on the test script. Nothing seems reliable on Github Actions.

[teverett]

@mike-lischke thanks!