Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift5] grammar fixes #4388

Merged
merged 12 commits into from
Feb 4, 2025
Merged

[Swift5] grammar fixes #4388

merged 12 commits into from
Feb 4, 2025

Conversation

samatanna
Copy link
Contributor

@samatanna samatanna commented Jan 21, 2025 •
edited
Loading

  1. Fix closure_parameter rule, add optional UNDERSCORE
    Closures don't have external parameter names, but underscore is allowed.
    The UNDERSCORE token definition has been moved before the IDENTIFIER token in the lexer, to use UNDERSCORE token in rule.
  2. Fix ambiguity of '?' token
  3. Add STRUCT token to identifier rule

@samatanna samatanna changed the title Fix closure_parameter rule, add optional UNDERSCORE Swift5 Fix closure_parameter rule, add optional UNDERSCORE Jan 21, 2025
@samatanna samatanna changed the title Swift5 Fix closure_parameter rule, add optional UNDERSCORE [Swift5] Fix closure_parameter rule, add optional UNDERSCORE Jan 21, 2025
@samatanna samatanna changed the title [Swift5] Fix closure_parameter rule, add optional UNDERSCORE [Swift5] grammar fixes Jan 31, 2025
@samatanna samatanna marked this pull request as ready for review January 31, 2025 14:01
@teverett
Copy link
Member

teverett commented Feb 4, 2025

@samatanna thanks!

@teverett teverett merged commit 14fc51d into antlr:master Feb 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeFather2 codeFather2 codeFather2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samatanna @teverett @codeFather2