Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of Shared Networks without IP range if network offering has no services - specifyvlan = true #10168

Merged
merged 5 commits into from
Jan 31, 2025

Check if associated networkId is passed when specify vlan is false

665283a
Select commit
Loading
Failed to load commit list.
Merged

Allow creation of Shared Networks without IP range if network offering has no services - specifyvlan = true #10168

Check if associated networkId is passed when specify vlan is false
665283a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 29, 2025 in 0s

0.00% of diff hit (target 15.14%)

View this Pull Request on Codecov

0.00% of diff hit (target 15.14%)

Annotations

Check warning on line 1639 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1639 

Added line #L1639 was not covered by tests
View more details on Codecov