feat: finish triple helloworld example #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubbo go shop framework
|
apache/dubbo-go#2425 has been merged. |
chickenlj
reviewed
Oct 11, 2023
api_new/greet.pb.go
Outdated
There was a problem hiding this comment.
I think it's not necessary to have a shared api_new package, instead, we can put api_new into each sample so that each directory contains the whole resources for it to run separately.
chickenlj
approved these changes
Oct 27, 2023
| go install google.golang.org/protobuf/cmd/[email protected] | ||
| ``` | ||
|
|
||
| ### install protoc-gen-triple |
There was a problem hiding this comment.
Should we rename to protoc-gen-triple-go or protoc-gen-go-triple to follow the protoc plugin naming convention?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, this PR is dependent on https://github.com/DMwangnima/dubbo-go/tree/feature-triple-server-layer. This would be changed to official branch when apache/dubbo-go#2425 is merged