Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8971] Fixing metadata metrics to honor metrics prefix #12797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsivabalan
Copy link
Contributor

@nsivabalan nsivabalan commented Feb 6, 2025

Change Logs

Fixing metadata metrics to honor metrics prefix.
Fix: Will honor the metrics prefix with "_metadata" suffixed.

For eg, incase of "clean_duration" metric:
with metrics prefix set to "ohds":
data table metric name => "ohds_clean_duration"
and metadata metric name => "ohds_metadata_clean_duration"

Impact

One set of metrics for metadata table.

I could not write an automated tests. But manually verified by using console metrics.

ohds.timer.deltastreamer
ohds_metadata.timer.deltacommit

Prior to the fix, each metric for metadata will have the table name prefixed w/ metric name. For datatable, still the metircsPrefix was honored.

ohds.timer.deltastreamer
hoodie_trips_metadata.timer.deltacommit

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 6, 2025
@hudi-bot
Copy link

hudi-bot commented Feb 6, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS PR with lines of changes in <= 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants