Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8988] Implement retry logic for all HTTP calls to timeline server including remote file system view and markers #12804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linliu-code
Copy link
Contributor

Change Logs

We have rolled back timeline based marker and are using direct markers for product due to an issue we have hit a few times, stacktrace shown in the ticket (NoHttpResponseException). The RCA is that there are no retries, and the requests may sometimes get assigned to a connection pool with a broken connection and fail. This is an issue specific to fluent HTTP client, and can be solved using retries.

Impact

It changes the code path for timeline network calls for Remote File System View and Markers.

Risk level (write none, low medium or high below)

Medium.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Feb 7, 2025
…eline server including remote file system view and markers (apache#912)

Co-authored-by: rmahindra123 <[email protected]>
@linliu-code linliu-code marked this pull request as ready for review February 7, 2025 04:30
@hudi-bot
Copy link

hudi-bot commented Feb 7, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L PR with lines of changes in (300, 1000]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants