Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink: Replace use of deprecated methods #11658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbonofre
Copy link
Member

This PR replaces use of deprecated method in Flink (1.20) tests.

@jbonofre jbonofre requested a review from pvary November 26, 2024 19:51
@github-actions github-actions bot added the flink label Nov 26, 2024
@jbonofre
Copy link
Member Author

@pvary I started some cleanups in Flink tests.

@pvary
Copy link
Contributor

pvary commented Nov 27, 2024

Why just these files/objects? I prefer a full removal of a method/class etc in a single PR. Otherwise we will end up with high number of small PRs which usually is a headache if internal versions are maintained.

Don't we want to do a full migration from path to location in a single PR?
The general TableSchema -> ResolvedSchema stuff is a bit more involved

@jbonofre
Copy link
Member Author

@pvary fair enough, let me "complete" this PR.

@nastra nastra changed the title Replace use of deprecated methods Flink: Replace use of deprecated methods Dec 2, 2024
Copy link

github-actions bot commented Jan 2, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 2, 2025
Copy link

github-actions bot commented Jan 9, 2025

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jan 9, 2025
@jbonofre
Copy link
Member Author

jbonofre commented Feb 1, 2025

I will resume this "cleaning" on Flink (I'm focusing on Flink right now).

@jbonofre jbonofre reopened this Feb 1, 2025
@github-actions github-actions bot removed the stale label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants