Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][MIRROR] Fix build faile don Macos with INSTALL_PREFIX not set #8654

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jackylee-ch
Copy link
Contributor

What changes were proposed in this pull request?

After #8627 , I met the dev/builddeps-veloxbe.sh: line 218: INSTALL_PREFIX: unbound variable.

How was this patch tested?

manual test on macos

@github-actions github-actions bot added the BUILD label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@jackylee-ch jackylee-ch changed the title [MIRROR] Fix build faile don Macos with INSTALL_PREFIX not set [MIRROR][BUILD] Fix build faile don Macos with INSTALL_PREFIX not set Feb 3, 2025
@jackylee-ch jackylee-ch changed the title [MIRROR][BUILD] Fix build faile don Macos with INSTALL_PREFIX not set [VL][MIRROR] Fix build faile don Macos with INSTALL_PREFIX not set Feb 3, 2025
Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@marin-ma marin-ma merged commit bef4cb2 into apache:main Feb 3, 2025
48 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_03_2025_time.csv log/native_master_02_02_2025_f898bc2425_time.csv difference percentage
q1 43.39 42.82 -0.570 98.69%
q2 44.60 45.63 1.037 102.32%
q3 90.75 93.01 2.255 102.48%
q4 68.78 69.15 0.363 100.53%
q5 180.14 182.76 2.618 101.45%
q6 17.87 17.99 0.121 100.68%
q7 105.10 105.12 0.015 100.01%
q8 187.26 185.94 -1.313 99.30%
q9 281.14 279.10 -2.031 99.28%
q10 100.49 101.66 1.168 101.16%
q11 33.96 34.32 0.358 101.06%
q12 43.40 43.81 0.411 100.95%
q13 75.81 77.12 1.306 101.72%
q14 38.45 35.63 -2.818 92.67%
q15 67.71 66.04 -1.674 97.53%
q16 26.89 27.31 0.420 101.56%
q17 234.94 230.68 -4.259 98.19%
q18 361.33 340.81 -20.522 94.32%
q19 38.64 37.26 -1.381 96.43%
q20 60.40 59.16 -1.244 97.94%
q21 531.83 536.21 4.384 100.82%
q22 23.87 24.60 0.733 103.07%
total 2656.77 2636.14 -20.624 99.22%

@jackylee-ch jackylee-ch deleted the mirror_fix_build_on_macos branch February 4, 2025 00:38
@jackylee-ch
Copy link
Contributor Author

Thanks for your review @marin-ma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants