bugfix:forget to set metrics & log ch as well (#155)

apache · Dec 5, 2023 · f9929c6 · f9929c6
1 parent 99c2c38
commit f9929c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -15,6 +15,7 @@ Release Notes.
 #### Bug Fixes
 * Fix users can not use async api in toolkit-trace.
 * Fix cannot enhance the vendor management project.
+* Fix SW_AGENT_REPORTER_GRPC_MAX_SEND_QUEUE not working on metricsSendCh & logSendCh chans of gRPC reporter.
 
 #### Issues and PR
 - All issues are [here](https://github.com/apache/skywalking/milestone/197?closed=1)

diff --git a/plugins/core/reporter/grpc/grpc_opts_enhance.go b/plugins/core/reporter/grpc/grpc_opts_enhance.go
@@ -28,6 +28,7 @@ import (
 	"google.golang.org/grpc/metadata"
 
 	agentv3 "skywalking.apache.org/repo/goapi/collect/language/agent/v3"
+	logv3 "skywalking.apache.org/repo/goapi/collect/logging/v3"
 )
 
 var authKey = "Authentication"
@@ -47,6 +48,8 @@ func WithCheckInterval(interval time.Duration) ReporterOption {
 func WithMaxSendQueueSize(maxSendQueueSize int) ReporterOption {
 	return func(r *gRPCReporter) {
 		r.tracingSendCh = make(chan *agentv3.SegmentObject, maxSendQueueSize)
+		r.metricsSendCh = make(chan []*agentv3.MeterData, maxSendQueueSize)
+		r.logSendCh = make(chan *logv3.LogData, maxSendQueueSize)
 	}
 }