Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing intercept point for gin, make sure interfaces could be group… #156

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

IceSoda177
Copy link
Contributor

Changing intercept point for gin, make sure interfaces could be grouped when params defined in relativePath.

@wu-sheng wu-sheng requested a review from mrproliu December 18, 2023 14:36
@wu-sheng wu-sheng added this to the 0.4.0 milestone Dec 18, 2023
@wu-sheng wu-sheng added enhancement New feature or request plugin labels Dec 18, 2023
@IceSoda177
Copy link
Contributor Author

Is this CI failure a problem? I think it's not code's fault.

@wu-sheng
Copy link
Member

Is this CI failure a problem? I think it's not code's fault.

I rerun the CIs.

@IceSoda177
Copy link
Contributor Author

IceSoda177 commented Dec 19, 2023

Is this CI failure a problem? I think it's not code's fault.

I rerun the CIs.

Looks like it fails again

@mrproliu
Copy link
Contributor

It looks like GitHub Action caused the failure, we can only run a few more times to try. :(

@IceSoda177
Copy link
Contributor Author

Sad...

@wu-sheng
Copy link
Member

@mrproliu Is there some env changed?

@IceSoda177
Copy link
Contributor Author

Same problems everytime, maybe some settings wrong?

@IceSoda177
Copy link
Contributor Author

Any news?

@wu-sheng wu-sheng merged commit 613c25b into apache:main Dec 19, 2023
33 checks passed
@wu-sheng
Copy link
Member

Any news?

We had fixed this, and now this is able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants