fix(openapi): typing issue with openapiContext in #[ApiProperty]
#6910
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Leading to `any` in Documentation When specify an `openapiContext` in #`[ApiProperty]`, the typing of the same property is no longer used, and force to explicitly specify it within the openapiContext array. Cfr: api-platform#6893
SebLevDev
changed the title
openapiContext in #[ApiProperty] Leading to any in DocumentationopenapiContext in #[ApiProperty]
SebLevDev
changed the title
openapiContext in #[ApiProperty]openapiContext in #[ApiProperty]
|
would you be able to add a non-regression test? I like the patch! |
Do you have a exemple of test for SchemaPropertyMetadataFactory.php |
|
This morning i found this I try t do that |
|
awesome thanks @SebLevDev ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specify an
openapiContextin #[ApiProperty], the typing of the same property is no longer used, and force to explicitly specify it within theopenapiContextarray.