feat: Python course lesson about getting links #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
added
the
t-academy
honzajavorek
requested review from
mnmkng,
vdusek,
metalwarrior665 and
TC-MO
mnmkng
reviewed
Sep 16, 2024
sources/academy/webscraping/scraping_basics_python/09_getting_links.md
Outdated
Show resolved
Hide resolved
honzajavorek
force-pushed
the
honzajavorek/py-urls
branch
2 times, most recently
from
1982944 to
377270a
Compare
vdusek
approved these changes
Oct 8, 2024
|
I do like type hints, more than before, but I'm afraid that in these code examples it would be more of a distraction. I don't have super strong opinion though and I can imagine adding the types later to the whole course, so I'd leave the decision for later. However, I promise I'll add testing of code examples! Just filed #1243 |
|
Waiting for one more approval from someone who checks the lesson from the writing point of view. It looks like @mnmkng has seen the lesson, but didn't leave a verdict. |
TC-MO
approved these changes
Oct 9, 2024
sources/academy/webscraping/scraping_basics_python/09_getting_links.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Olender <[email protected]>
honzajavorek
force-pushed
the
honzajavorek/py-urls
branch
from
c1845c6 to
6ca5b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dared to include my favorite gif that dates back to ancient Apiary times with @netmilk.