Skip to content

Commit

Permalink
fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
ShohamBit committed Feb 5, 2025
1 parent 914e3cf commit b8db1e4
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 23 deletions.
8 changes: 4 additions & 4 deletions cmd/traceectl/cmd/event.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/spf13/viper"

"github.com/aquasecurity/tracee/cmd/traceectl/pkg/client"
cmdCobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
cmdcobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/flags"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/printer"
)
Expand Down Expand Up @@ -87,7 +87,7 @@ var describeEventCmd = &cobra.Command{
Long: `Lists all available event definitions (built-in and plugin-defined), providing a brief summary of each.`,
Args: cobra.MaximumNArgs(1),
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetDescribeEvent(cmd)
runner, err := cmdcobra.GetDescribeEvent(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand All @@ -106,7 +106,7 @@ var enableEventCmd = &cobra.Command{
Long: `Enables capturing of a specific event type.`,
Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetEnableEvent(cmd)
runner, err := cmdcobra.GetEnableEvent(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand All @@ -125,7 +125,7 @@ var disableEventCmd = &cobra.Command{
Long: `Disables capturing of a specific event type.`,
Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetDisableEvent(cmd)
runner, err := cmdcobra.GetDisableEvent(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand Down
4 changes: 2 additions & 2 deletions cmd/traceectl/cmd/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/spf13/viper"

"github.com/aquasecurity/tracee/cmd/traceectl/pkg/client"
cmdCobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
cmdcobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/flags"
)

Expand All @@ -16,7 +16,7 @@ var metricsCmd = &cobra.Command{
Short: "Display Tracee metrics",
Long: "Retrieves metrics about Tracee's performance and resource usage.",
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetMetrics(cmd)
runner, err := cmdcobra.GetMetrics(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand Down
4 changes: 2 additions & 2 deletions cmd/traceectl/cmd/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/spf13/viper"

"github.com/aquasecurity/tracee/cmd/traceectl/pkg/client"
cmdCobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
cmdcobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/flags"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/printer"
)
Expand All @@ -19,7 +19,7 @@ var streamCmd = &cobra.Command{
Stream events directly from tracee to the preferred output format.
`,
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetStream(cmd)
runner, err := cmdcobra.GetStream(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand Down
4 changes: 2 additions & 2 deletions cmd/traceectl/cmd/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/spf13/viper"

"github.com/aquasecurity/tracee/cmd/traceectl/pkg/client"
cmdCobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
cmdcobra "github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/cobra"
"github.com/aquasecurity/tracee/cmd/traceectl/pkg/cmd/flags"
)

Expand All @@ -16,7 +16,7 @@ var versionCmd = &cobra.Command{
Short: "Display the version of tracee",
Long: "This is the version of the tracee application you connected to",
Run: func(cmd *cobra.Command, args []string) {
runner, err := cmdCobra.GetVersion(cmd)
runner, err := cmdcobra.GetVersion(cmd)
if err != nil {
cmd.PrintErrf("error creating runner: %s\n", err)
os.Exit(1)
Expand Down
1 change: 0 additions & 1 deletion cmd/traceectl/pkg/cmd/flags/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,4 @@ func PrepareOutput(cmd *cobra.Command, outputSlice string) (Output, error) {
Path: outputSlice,
Writer: cmd.OutOrStdout(),
}, nil

}
1 change: 0 additions & 1 deletion cmd/traceectl/pkg/cmd/flags/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ func PrepareServer(serverSlice string) (*client.Server, error) {
return server, err
}
return server, nil

}
1 change: 0 additions & 1 deletion cmd/traceectl/pkg/cmd/flags/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ func TestPrepareServer(t *testing.T) {
if assert.Equal(t, testcase.expectedServer, server) {
return
}

})
}
if err := mockServer.TeardownMockSocket(); err != nil {
Expand Down
8 changes: 4 additions & 4 deletions cmd/traceectl/pkg/cmd/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ func (m Metrics) Run() error {
if err != nil {
return fmt.Errorf("error getting metrics: %s", err)
}
if metricsJson, err := response.MarshalJSON(); err != nil {
metricsJson, err := response.MarshalJSON()
if err != nil {
panic(err)
} else {
m.Printer.Printf("\n%s\n", metricsJson)
return nil
}
m.Printer.Printf("\n%s\n", metricsJson)
return nil
}
1 change: 0 additions & 1 deletion cmd/traceectl/pkg/cmd/printer/event.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ func (p *tableDescribeEventsPrinter) Print(definition *pb.EventDefinition) {
strings.Join(definition.Tags, ", "),
definition.Description,
)

}

func (p *tableDescribeEventsPrinter) Init() error {
Expand Down
6 changes: 3 additions & 3 deletions cmd/traceectl/pkg/cmd/printer/printer.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ func (p tableEventPrinter) Preamble() {
}

func (p tableEventPrinter) Epilogue(metrics *pb.GetMetricsResponse) {
if metricsJson, err := metrics.MarshalJSON(); err != nil {
metricsJson, err := metrics.MarshalJSON()
if err != nil {
panic(err)
} else {
p.cmd.Printf("\n%s\n", metricsJson)
}
p.cmd.Printf("\n%s\n", metricsJson)
}

func (p tableEventPrinter) Print(event *pb.Event) {
Expand Down
3 changes: 1 addition & 2 deletions cmd/traceectl/pkg/cmd/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func (s Stream) Run() error {
return fmt.Errorf("error running stream: %s", err)
}
defer s.Server.Close()
//create signal chanel
// create signal chanel
sigs := make(chan os.Signal, 1)
signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)

Expand Down Expand Up @@ -76,5 +76,4 @@ func (s Stream) Run() error {
return err
}
}

}

0 comments on commit b8db1e4

Please sign in to comment.