WIP: Feat date picker range #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/arcodesign/components/date-picker/index.tsx # packages/arcodesign/components/date-picker/type.ts
|
单测fail了需要解决下哦~ |
# Conflicts: # packages/arcodesign/tokens/src/arcodesign/default/index.js
…co-design-mobile into feat-date-picker # Conflicts: # packages/arcodesign/components/date-picker/index.tsx
adaex
added
the
WIP
There was a problem hiding this comment.
Copilot reviewed 6 out of 17 changed files in this pull request and generated no suggestions.
Files not reviewed (11)
- packages/arcodesign/components/date-picker/test/snapshots/index.spec.js.snap: Language not supported
- packages/arcodesign/components/date-picker/style/index.less: Language not supported
- packages/arcodesign/tokens/app/arcodesign/default/css-variables.less: Language not supported
- packages/arcodesign/tokens/app/arcodesign/default/index.json: Language not supported
- packages/arcodesign/tokens/app/arcodesign/default/index.less: Language not supported
- packages/arcodesign/components/date-picker/test/index.spec.js: Evaluated as low risk
- packages/arcodesign/components/picker/index.tsx: Evaluated as low risk
- packages/arcodesign/components/stepper/hooks/useValue.tsx: Evaluated as low risk
- packages/arcodesign/tokens/app/arcodesign/default/index.js: Evaluated as low risk
- packages/arcodesign/components/date-picker/type.ts: Evaluated as low risk
- packages/arcodesign/tokens/src/arcodesign/default/theme.js: Evaluated as low risk
Comments skipped due to low confidence (1)
packages/arcodesign/components/date-picker/index.tsx:65
- The dependency array for useMemo should include leftTimeValue to ensure correct updates: [userSetMinTs, userSetMaxTs, activeTabIndex, leftTimeValue].
const [minTs, maxTs] = useMemo(() => { return _updateTimeScope(); }, [userSetMinTs, userSetMaxTs, activeTabIndex]);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.