Bugfixes on tests and github actions runner for Windows

.github/workflows/unit-test.yml

@@ -0,0 +1,58 @@
+name: Arduino IDE unit test run
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  test-linux:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up JDK 1.8
+      uses: actions/setup-java@v1
+      with:
+        java-version: 1.8
+    - name: Build with Ant
+      working-directory: ./build
+      run: ant clean build
+    - name: Install X virtual framebuffer
+      run: sudo apt-get install -y xvfb
+    - name: Run tests
+      working-directory: ./build
+      run: xvfb-run --auto-servernum --server-args "-screen 0 1024x768x24" ant test -Drunning-from-github-action=1
+    - name: Publish results
+      if: always()
+      uses: actions/upload-artifact@v2
+      with:
+        name: html-results-linux
+        path: app/test-bin/results/html/
+    - name: Cleanup xvfb
+      uses: bcomnes/cleanup-xvfb@v1
+
+  test-windows:
+    runs-on: windows-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Download JDK 1.8 for Windows/x86
+      run: curl -O "https://cdn.azul.com/zulu/bin/zulu8.46.0.19-ca-jdk8.0.252-win_i686.zip"
+    - name: Set up JDK 1.8
+      uses: actions/setup-java@master
+      with:
+        version: 1.8
+        architecture: x86
+        jdkFile: ./zulu8.46.0.19-ca-jdk8.0.252-win_i686.zip
+    - name: Build with Ant
+      working-directory: ./build
+      run: |
+        java -version
+        ant clean build
+    - name: Run tests
+      working-directory: ./build
+      run: ant test -Drunning-from-github-action=1
+    - name: Publish results
+      if: always()
+      uses: actions/upload-artifact@v2
+      with:
+        name: html-results-win
+        path: app/test-bin/results/html/

app/.classpath

@@ -45,14 +45,16 @@
 	<classpathentry kind="lib" path="lib/xml-apis-1.3.04.jar"/>
 	<classpathentry kind="lib" path="lib/xml-apis-ext-1.3.04.jar"/>
 	<classpathentry kind="lib" path="lib/xmlgraphics-commons-2.0.jar"/>
-	<classpathentry kind="lib" path="test-lib/junit-4.11.jar"/>
-	<classpathentry kind="lib" path="test-lib/fest-assert-1.2.jar"/>
-	<classpathentry kind="lib" path="test-lib/fest-reflect-1.2.jar"/>
-	<classpathentry kind="lib" path="test-lib/fest-swing-1.2.jar"/>
-	<classpathentry kind="lib" path="test-lib/fest-util-1.1.2.jar"/>
 	<classpathentry kind="lib" path="test-lib/jcip-annotations-1.0.jar"/>
 	<classpathentry kind="lib" path="lib/jtouchbar-1.0.0.jar"/>
 	<classpathentry kind="lib" path="lib/commons-lang3-3.8.1.jar"/>
 	<classpathentry kind="lib" path="lib/jssc-2.8.0-arduino4.jar"/>
+	<classpathentry kind="lib" path="test-lib/assertj-swing-junit-3.9.2.jar"/>
+	<classpathentry kind="lib" path="test-lib/assertj-core-1.7.1.jar"/>
+	<classpathentry kind="lib" path="test-lib/assertj-swing-1.2.0.jar"/>
+	<classpathentry kind="lib" path="test-lib/assertj-swing-junit-1.2.0.jar"/>
+	<classpathentry kind="lib" path="test-lib/assertj-swing-junit-4.5-1.2.0.jar"/>
+	<classpathentry kind="lib" path="test-lib/fest-util-1.2.5.jar"/>
+	<classpathentry kind="lib" path="test-lib/junit-4.5.jar"/>
 	<classpathentry kind="output" path="bin"/>
 </classpath>

app/build.xml

@@ -123,6 +123,7 @@
     <fail message="Need single-test-class if single-test-methods is set" if="single-test-methods" unless="single-test-class"/>
 
     <junit printsummary="yes" dir="${work.dir}" fork="true" showoutput="no" failureproperty="test.failed">
+      <jvmarg value="-Dlog4j.dir=."/>
       <jvmarg value="-Djava.library.path=${java.additional.library.path}"/>
       <jvmarg value="-DWORK_DIR=."/>
       <jvmarg value="-ea"/>
@@ -135,10 +136,8 @@
       </classpath>
 
       <!-- Write XML files (for report-generation) and TXT files (for manual review) for every test class -->
-      <formatter type="plain" />
+      <formatter type="plain" usefile="false" /> <!-- to screen -->
       <formatter type="xml"/>
-      <!-- Print full details to stdout when running a single test -->
-      <formatter type="plain" usefile="false" if="single-test-class"/>
       <!-- When running all tests, print details for failing tests and a summary for each test class (printsummary=yes above) -->
       <formatter type="brief" usefile="false" unless="single-test-class"/>
 

app/src/processing/app/EditorConsole.java

@@ -231,7 +231,13 @@ public void insertString(String str, SimpleAttributeSet attributes) throws BadLo
   }
 
   public String getText() {
-    return consoleTextPane.getText();
+    try {
+      return document.getText(0, document.getLength());
+    } catch (BadLocationException e) {
+      // Should never happen...
+      e.printStackTrace();
+      return "";
+    }
   }
 
 }

app/test/cc/arduino/contributions/.gitattributes

@@ -0,0 +1 @@
+package_index.json*	-text

app/test/processing/app/AbstractGUITest.java

@@ -29,17 +29,15 @@
 
 package processing.app;
 
-import cc.arduino.files.DeleteFilesOnShutdown;
-import org.fest.swing.edt.FailOnThreadViolationRepaintManager;
-import org.fest.swing.edt.GuiActionRunner;
-import org.fest.swing.edt.GuiQuery;
+import javax.swing.JPopupMenu;
+
+import org.assertj.swing.edt.FailOnThreadViolationRepaintManager;
+import org.assertj.swing.edt.GuiActionRunner;
+import org.assertj.swing.edt.GuiQuery;
 import org.junit.After;
 import org.junit.Before;
-import processing.app.helpers.ArduinoFrameFixture;
-import processing.app.helpers.FileUtils;
 
-import javax.swing.*;
-import java.util.Random;
+import processing.app.helpers.ArduinoFrameFixture;
 
 public abstract class AbstractGUITest extends AbstractWithPreferencesTest {
 

app/test/processing/app/AutoformatProducesOneUndoActionTest.java

@@ -29,12 +29,13 @@
 
 package processing.app;
 
-import org.fest.swing.fixture.JMenuItemFixture;
 import org.junit.Test;
 import processing.app.helpers.SketchTextAreaFixture;
 
 import static org.junit.Assert.assertEquals;
 
+import org.assertj.swing.fixture.JMenuItemFixture;
+
 public class AutoformatProducesOneUndoActionTest extends AbstractGUITest {
 
   public static final String SOURCE_BEFORE = "void setup() {\n" +