-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keycloak SSO #5711
base: refactor/argilla-server/better-oauth2-integration
Are you sure you want to change the base?
Add keycloak SSO #5711
Conversation
… feature/better-oauth2-integration-keycloak
Related #5691 |
argilla-server/src/argilla_server/security/authentication/oauth2/_backends.py
Outdated
Show resolved
Hide resolved
… feature/better-oauth2-integration-keycloak
argilla-server/src/argilla_server/security/authentication/oauth2/_backends.py
Show resolved
Hide resolved
… feature/better-oauth2-integration-keycloak
I tested it a bit with a local set-up but it does not seem to work. I need some time to debug it, to understand why it is not working. |
cc5ca0c
to
bf2a0f6
Compare
I've pushed some missing tests to see the expected values https://github.com/argilla-io/argilla/blob/bf2a0f64a991731602cd521188dd95bb3896d7ea/argilla-server/tests/unit/api/handlers/v1/test_oauth2.py |
Just wanted to check if you need any help with this? Really looking forward to this feature |
@bulatovv @frascuchon I just started looking at it again after being on vacation for a while. What I see is the following behaviour:
I'm looking at those things right now. Generally speaking the simple authentification with Keycloak works, what does not work are the roles & workspace assignments |
reflect a change in the Oauth role change
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@frascuchon I updated the code for the cases that where failing for me:
could you check specifically in the oauth2.py if the changes against the DB are correctly implemented. |
Thanks, @paulbauriegel, and sorry for the late response. I need to review your changes in deep since some of them could comprise other OAuth flows. Maybe the safer way would be a specific step syncing SSO roles and workspaces with the argilla DB. |
Add keycloak SSO
Based on discussion in #5691
Points that need some feedback:
Type of change
How Has This Been Tested
Local build & Keycloak installation as described in the documentation.
Checklist